Thanks for the PR and for spending time on this, but

1. Feature request non-root user #407 is a feature request not a bug, so there's nothing to 'fix'
2. It's a feature that the project doesn't want or need, so issue Feature request non-root user #407 is closed and this PR won't get merged
3. If the person who raised Feature request non-root user #407 wants to use your change they can pull it into their own fork

So thanks again, and I will close this PR

@petefoth Oh, I am a bit surprised by your reaction. Your last comment in #407:

It is relatively straightforward to build your own docker image, based on this image, with the changes you need. If you can make the changes work for you , then the project would be happy to consider a pull request to make them available in this image.

suggested to me you would be happy about this PR. May I ask what changed your mind? Why does the project from your point of view does not want or need this feature? I implemented this PR not only because of the OP of #407. I certainly also need this functionality. It is otherwise a pain to develop and port for lineagos / microg in linux. One would need to change permissions of the mounted volume files and folders all the time if this functionality is missing (this means changing ownership of alot of files ... the whole Lineagos source tree). So I am very interested why you don't think this is needed and do not want it anymore. Maybe the whole thing is just a misunderstanding?

About the wording 'fix', well sure, I can certainly change that in the merge request description. I just used it as then the PR automatically gets referenced in the issue.

best

OK. Firstly my apologies for my previous response: I shouldn't respond to PRs late at night without spending enough time thinking about them.

Secondly,

Why does the project from your point of view does not want or need this feature?

We don't need it, because

• we always run out builds as root
• other users can run builds without root using the rootless setup referenced in the issue. This is how I use it for my own builds when building locally.

We (I) don't particularly want it because:

1. any change risks breaking existing functionality;
2. this change adds a level of complexity - not huge, but there nevertheless;
3. to justify the risk, the change needs to bring significant benefit. I am still not sure what benefit this feature provides. I'm happy to accept that at least one or two users would find it useful. I'm still not sure that this is enough of a benefit to justify the risk.
   • @ShadwDrgn is this still functionality you need?
   • @derMart would you use this functionality if it is merged?

However, I will reopen the PR. But before I would consider merging it, I would need to know what testing of the changes has been carried out. In particular I need to know that as, well as allowing the functionality it implements, it does not break the existing functionality of

1. running docker as root
2. running docker 'rootless'

I don't have time or resources to do that testing, so I would need to know that the testing has been done and has succeeded.

any change risks breaking existing functionality;

Re-opening the PR causes some checks to be run automatically. These checks have failed - running ShellCheck failed

./src/root_init.sh:22:41: note: Use -n instead of ! -z. [SC2236]
./src/root_init.sh:23:15: note: Double quote to prevent globbing and word splitting. [SC2086]
./src/root_init.sh:23:25: note: Double quote to prevent globbing and word splitting. [SC2086]
./src/root_init.sh:24:27: note: Double quote to prevent globbing and word splitting. [SC2086]
./src/root_init.sh:24:50: note: Double quote to prevent globbing and word splitting. [SC2086]
./src/root_init.sh:27:10: note: Double quote to prevent globbing and word splitting. [SC2086]
./src/root_init.sh:27:18: note: Double quote to prevent globbing and word splitting. [SC2086]
./src/root_init.sh:29:26: note: Double quote to prevent globbing and word splitting. [SC2086]

See https://github.com/lineageos4microg/docker-lineage-cicd/actions/runs/11549112512/job/32141609648